Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications label in room list is confusing #18139

Closed
nadonomy opened this issue Jul 21, 2021 · 10 comments · Fixed by matrix-org/matrix-react-sdk#6431
Closed

Notifications label in room list is confusing #18139

nadonomy opened this issue Jul 21, 2021 · 10 comments · Fixed by matrix-org/matrix-react-sdk#6431
Assignees
Labels
A-Notifications P1 S-Minor Impairs non-critical functionality or suitable workarounds exist Sponsored T-Defect X-Release-Blocker

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Jul 21, 2021

Screenshot 2021-07-21 at 11 16 42

Left: Production. Right: Develop.

The tweak on develop relabelling 'Use default' to 'Global' is confusing in practise. In context, 'Global' seems like a type of notification and causes me to pause and think.

@gaelledel what could we do to tweak? Is there something we could do where we use a more predictable term in the context menu on the room list, and add some micro copy to Settings to aid?

@gaelledel
Copy link

Default doesn't work either as these are really more based on user's own decisions. So as an alternative I suggest:

In the contextual menu: Custom/Customised, Personalised, or Selective

In the core settings: Custom notifications, Personalised notifications, Selective notifications

@gaelledel
Copy link

I have a preference for the word Custom if you'd ask me. Let me know so I can let the devs know

@robintown robintown added A-Notifications S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design labels Jul 21, 2021
@SimonBrandner
Copy link
Contributor

Custom sounds even more confusing to me, tbh. I would expect a modal to appear which would let me configure per-room keywords or whatever, which isn't the thing I should expect at all

@nadonomy
Copy link
Contributor Author

nadonomy commented Jul 21, 2021

@gaelledel I don't think Custom is appropriate as this is the default selection for everyone.

Default doesn't work either as these are really more based on user's own decisions.

This is the out of the box, starting, choice though so isn't based on any user's own decisions. If users do delve into Settings to tweak they can carry that cognitive load forward, but for this interaction we should optimise for it to make sense for (1) new users and (2) committed users who in this context want to override their default/account settings for a specific room quickly and at a glance.

What else could we do?

@t3chguy
Copy link
Member

t3chguy commented Jul 21, 2021

In the long term, with the FTUE Notifications project this'll improve to have very similarly named interactions between Settings > Notifications and the Room notifications override context menu but with push rules that's prohibitively complex and flakey to do

@nadonomy
Copy link
Contributor Author

@dbkr btw would be good to tag/flag this as a release blocker ahead of Tuesdays RC (not sure of the best way/which board to do that in?).

It'll be trivial to implement once we have clarity on the right copy, but would be a shame for this to slip to production as is.

@gaelledel
Copy link

Have told development to revert back to original terminology

@t3chguy
Copy link
Member

t3chguy commented Jul 21, 2021

@nadonomy that is just a label in GH ^

@turt2live turt2live self-assigned this Jul 21, 2021
@turt2live turt2live added the P1 label Jul 21, 2021
@nadonomy
Copy link
Contributor Author

@nadonomy that is just a label in GH ^

Wasn't sure if the label is actively being looked at per release cycle. Assuming from @turt2live self-assigning everything is in hand!

@turt2live
Copy link
Member

yup, it got raised oob and is part of a sponsored project. Should be up for review soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications P1 S-Minor Impairs non-critical functionality or suitable workarounds exist Sponsored T-Defect X-Release-Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants