Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-app link navigation broke on Element Nightly and develop #20715

Closed
thibaultamartin opened this issue Jan 24, 2022 · 5 comments · Fixed by matrix-org/matrix-react-sdk#7627
Closed

In-app link navigation broke on Element Nightly and develop #20715

thibaultamartin opened this issue Jan 24, 2022 · 5 comments · Fixed by matrix-org/matrix-react-sdk#7627
Assignees
@jryans
Labels
A-Matrix.to O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@thibaultamartin
Copy link
Contributor

Steps to reproduce

  1. Someone sends a matrix.to link in a room
  2. Click the link
  3. The browser opens, instead of Element following the link

Outcome

What did you expect?

I would expect Element to follow the matrix.to link

What happened instead?

The browser opens

Operating system

macOS

Application version

Element Nightly version: 2022012401

How did you install the app?

https://element.io/get-started#nightly

Homeserver

ergaster.org

Will you send logs?

Yes
@SimonBrandner SimonBrandner added A-Matrix.to S-Minor Impairs non-critical functionality or suitable workarounds exist X-Regression X-Release-Blocker O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jan 24, 2022
@jryans
Copy link
Collaborator

jryans commented Jan 24, 2022

@thibaultamartin Could you provide more detail on the specific link you tried? On my first attempt, I was navigated inside Element, so it may come down to the precise link type.

Feel free to message me privately if needed.

@t3chguy t3chguy mentioned this issue Jan 24, 2022
Closed
@turt2live
Copy link
Member

For me this broke with a pill (from a bot, but rendered as a pill). See #20719

@jryans
Copy link
Collaborator

jryans commented Jan 24, 2022

I can try to take a look tomorrow morning if no one picks this up before.

@turt2live turt2live mentioned this issue Jan 24, 2022
Closed
@thibaultamartin
Copy link
Contributor Author

@thibaultamartin Could you provide more detail on the specific link you tried? On my first attempt, I was navigated inside Element, so it may come down to the precise link type.

It seems to be links to a message. For TWIM, my bot gives me a link to the messages people sent to report news. A typical link will be https://matrix.to/#/!QQpfJfZvqxbCfeDgCj:matrix.org/$yR7i-3aGQ_Ztbhj5wJAx_Gq6NBml8PX9gbIijD43UgU

I just tested: links to a room (e.g. https://matrix.to/#/#sliding-sync:matrix.org) do work correctly

@jryans jryans self-assigned this Jan 25, 2022
@jryans
Copy link
Collaborator

jryans commented Jan 25, 2022

I'll see what I can do here.

@jryans jryans changed the title matrix.to links broke on Element Nightly and develop In-app link navigation broke on Element Nightly and develop Jan 25, 2022
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 25, 2022
@jryans
Add body link fallback handler for in-app navigation
0739eaf 
This adds a fallback click handler for all links in the message to ensure that
links that were ignored as part of linkification (e.g. pills, links in message
content) will still navigate in-app where possible.

This approach preserves a side-benefit of
#7453, which kept all link
hrefs as matrix.to style links (so that they can be easily copied and shared).

Fixes element-hq/element-web#20715
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 25, 2022
@jryans
Add body link fallback handler for in-app navigation
7bc958f 
This adds a fallback click handler for all links in the message to ensure that
links that were ignored as part of linkification (e.g. pills, links in message
content) will still navigate in-app where possible.

This approach preserves a side benefit of
#7453, which kept all link
hrefs as matrix.to style links (so that they can be easily copied and shared).

Fixes element-hq/element-web#20715
@jryans jryans mentioned this issue Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Matrix.to O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add body link fallback handler for in-app navigation matrix-org/matrix-react-sdk
4 participants
@jryans @turt2live @thibaultamartin @SimonBrandner