Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET calls unstable instead of stable #22839

Closed
thepra opened this issue Jul 13, 2022 · 2 comments · Fixed by matrix-org/matrix-js-sdk#2729
Closed

GET calls unstable instead of stable #22839

thepra opened this issue Jul 13, 2022 · 2 comments · Fixed by matrix-org/matrix-js-sdk#2729
Assignees
@turt2live
Labels
A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Spec-Compliance An area where Element doesn't correctly implement the spec

Comments

@thepra
Copy link

thepra commented Jul 13, 2022

Steps to reproduce

  1. Where are you starting? What can you see?
    Homepage post-login as admin, I can see placeholders of rooms that remain placeholders

Outcome

What did you expect?

The client making calls to stable path I guess.

What happened instead?

I have the client calling _matrix/client/unstable/room_keys/version when I did download the stable version 1.11.0 of the client

Operating system

Ubuntu

Browser information

Firefox 103

URL for webapp

chat.zigzag.academy

Application version

Element version: 1.11.0, Olm version: 3.2.8

Homeserver

zigzag.academy, Dendrite

Will you send logs?

No
@turt2live turt2live self-assigned this Jul 13, 2022
@turt2live turt2live added the Z-Spec-Compliance An area where Element doesn't correctly implement the spec label Jul 13, 2022
@thepra
Copy link
Author

thepra commented Jul 13, 2022

Is there any fix that I could perform locally to fix this?

@turt2live
Copy link
Member

not without forking Element, unfortunately.

@robertlong robertlong added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist A-Room-List T-Defect and removed T-Defect labels Jul 13, 2022
@kfiven kfiven mentioned this issue Jul 15, 2022
Closed
turt2live added a commit to matrix-org/matrix-js-sdk that referenced this issue Oct 4, 2022
@turt2live
Use stable calls to /room_keys
b62c205 
Fixes element-hq/element-web#22839
@turt2live turt2live mentioned this issue Oct 4, 2022
Merged
turt2live added a commit to matrix-org/matrix-js-sdk that referenced this issue Oct 4, 2022
@turt2live
Use stable calls to /room_keys (#2729)
b1ed972 
* Use stable calls to `/room_keys`

Fixes element-hq/element-web#22839

* Appease the CI
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Oct 29, 2022
@su-ex
Merge tag 'v21.0.0' into sc
9b20f5c 
* Changes the `uploadContent` API, kills off `request` and `browser-request` in favour of `fetch`, removed callback support on a lot of the methods, adds a lot of tests. ([\matrix-org#2719](matrix-org#2719)). Fixes matrix-org#2415 and matrix-org#801.
* Remove deprecated `m.room.aliases` references ([\matrix-org#2759](matrix-org#2759)). Fixes element-hq/element-web#12680.
* Remove node-specific crypto bits, use Node 16's WebCrypto ([\matrix-org#2762](matrix-org#2762)). Fixes matrix-org#2760.
* Export types for MatrixEvent and Room emitted events, and make event handler map types stricter ([\matrix-org#2750](matrix-org#2750)). Contributed by @stas-demydiuk.
* Use even more stable calls to `/room_keys` ([\matrix-org#2746](matrix-org#2746)).
* Upgrade to Olm 3.2.13 which has been repackaged to support Node 18 ([\matrix-org#2744](matrix-org#2744)).
* Fix `power_level_content_override` type ([\matrix-org#2741](matrix-org#2741)).
* Add custom notification handling for MSC3401 call events  ([\matrix-org#2720](matrix-org#2720)).
* Add support for unread thread notifications ([\matrix-org#2726](matrix-org#2726)).
* Load Thread List with server-side assistance (MSC3856) ([\matrix-org#2602](matrix-org#2602)).
* Use stable calls to `/room_keys` ([\matrix-org#2729](matrix-org#2729)). Fixes element-hq/element-web#22839.
* Fix POST data not being passed for registerWithIdentityServer ([\matrix-org#2769](matrix-org#2769)). Fixes matrix-org/element-web-rageshakes#16206.
* Fix IdentityPrefix.V2 containing spurious `/api` ([\matrix-org#2761](matrix-org#2761)). Fixes element-hq/element-web#23505.
* Always send back an httpStatus property if one is known ([\matrix-org#2753](matrix-org#2753)).
* Check for AbortError, not any generic connection error, to avoid tightlooping ([\matrix-org#2752](matrix-org#2752)).
* Correct the dir parameter of MSC3715 ([\matrix-org#2745](matrix-org#2745)). Contributed by @dhenneke.
* Fix sync init when thread unread notif is not supported ([\matrix-org#2739](matrix-org#2739)). Fixes element-hq/element-web#23435.
* Use the correct sender key when checking shared secret ([\matrix-org#2730](matrix-org#2730)). Fixes element-hq/element-web#23374.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Spec-Compliance An area where Element doesn't correctly implement the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use stable calls to /room_keys matrix-org/matrix-js-sdk
3 participants
@turt2live @robertlong @thepra