Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better parity with slack emoji #5291

Closed
ara4n opened this issue Oct 15, 2017 · 11 comments · Fixed by matrix-org/matrix-react-sdk#2085 or matrix-org/matrix-react-sdk#4391
Closed

better parity with slack emoji #5291

ara4n opened this issue Oct 15, 2017 · 11 comments · Fixed by matrix-org/matrix-react-sdk#2085 or matrix-org/matrix-react-sdk#4391

Comments

@ara4n
Copy link
Member

ara4n commented Oct 15, 2017

people spend their lives sending me :+1: etc. rather than blindly using emoji-one codes we should make more of an effort to be usable by slack afficionados

@lampholder
Copy link
Member

You mean you get the raw text :+1: (which github obvs helpfully renders as a thumbs-up).

Yeah; this shouldn't be too hard to do.

@lampholder lampholder added the P3 label Oct 16, 2017
@lampholder
Copy link
Member

I think we'd want to support multiple names for emojis, rather than replace :thumbsup: with :+1:.

@ara4n ara4n added P1 and removed P3 labels Oct 28, 2017
@ara4n
Copy link
Member Author

ara4n commented Oct 28, 2017

This is P1 because it's a horrid experience for people migrating from Slack, and it's trivial to do.

@lukebarnard1
Copy link
Contributor

This seems ambiguous to me. Can someone spell this out? Do we:

  1. turn :xxxx: into an emoji when the second ":" is typed?
  2. turn :xxxx: into an emoji when the message is sent?
  3. improve our emoji meta data to include slack aliases?

@ara4n
Copy link
Member Author

ara4n commented Nov 3, 2017

We're talking about option 3 in this one.

There could be a separate option to interpret the second colon as an autocomplete, but that's pretty evil (right up there with autoturning :) into 😄) and should absolutely not be on by default - and should be a separate bug, if it isn't already.

@ara4n ara4n removed the ambiguous label Nov 3, 2017
@t3chguy
Copy link
Member

t3chguy commented Jul 24, 2018

EmojiOne already has a list of aliases which are what Slack uses to refer to their emoji by

@t3chguy
Copy link
Member

t3chguy commented Jul 25, 2018

So matrix-org/matrix-react-sdk#2085 has landed which does this somewhat, some improvements are needed as noted in the PR summary

@turt2live
Copy link
Member

ftr, emojione is being removed (#9281) but this issue still applies in that we need to have more aliases.

@jryans jryans added the A-Emoji label May 30, 2019
@t3chguy
Copy link
Member

t3chguy commented Sep 11, 2019

new emoji data helps with this:

image
image

@t3chguy
Copy link
Member

t3chguy commented Apr 11, 2020

as per #5291 (comment) this is resolved, the above referenced PR improves the sorting such that +1 -1 are first results.

@t3chguy t3chguy self-assigned this Apr 11, 2020
@t3chguy
Copy link
Member

t3chguy commented Apr 14, 2020

The remaining above issue is tracked as #7256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment