Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory usage of Riot has increased quite a lot #5660

Closed
turt2live opened this issue Nov 20, 2017 · 10 comments
Closed

Memory usage of Riot has increased quite a lot #5660

turt2live opened this issue Nov 20, 2017 · 10 comments
Labels
A-Performance P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@turt2live
Copy link
Member

Description

I have a fairly large account that sits in 820 rooms, so it's not all that surprising that Riot uses a good chunk of my RAM. Over the last couple weeks I've noticed the RAM usage getting steadily higher, despite not joining more than a few rooms. Approximately a month ago the RAM usage was hovering around 1.2GB, and now it's anywhere between 1.7 and 2GB. I'm working on getting a memory snapshot, however the footprint is so large that chrome needs some extra flags to get the dump.

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 62
  • OS: Windows 10
  • URL: riot.im/develop
@lampholder lampholder added T-Defect P1 A-Performance S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Nov 23, 2017
@lampholder
Copy link
Member

Do we have any ideas why this might be?

Potentially related to #3307

@turt2live
Copy link
Member Author

It helped a bit to clear out the rageshake logs, however that only fixed the issue for a short while. I was seeing ~2GB of strings being loaded due to rageshake :(

@grahamperrin
Copy link

https://matrix.to/#/!DgvjtOljKujDBrxyHk:matrix.org/$15146526923278095CKgBf:matrix.org (2017-12-30):

Is it reasonable for the web app to use more than 1 G memory?

https://matrix.org/_matrix/media/v1/download/matrix.org/buFeNpKqWJVDrAWLxuqxbBAc

https://matrix.to/#/!DgvjtOljKujDBrxyHk:matrix.org/$15146764903622711dLWLX:matrix.org @ara4n replied:

yup, riot/web memory usage sucks atm and we need to improve it

Two frames from a (long) screen recording, made this morning (for a variety of purposes, not solely for Riot). The leap in use of virtual memory by Waterfox – from 4,811 M to 10.8 G, when https://riot.im/app/#/room/#mozilla_#firefox:matrix.org begins to load – is entertaining (not alarming):

2018-02-04 08 44 54 frame

2018-02-04 08 44 58 frame

:-) yeah, I could use fewer extensions, but the sixty-something that are currently enabled are a good fit for my workflows.

@hrj
Copy link

hrj commented Feb 11, 2018

Do we have any ideas why this might be?

I wouldn't like to share a heap snapshot publicly, but I could share some statistics:

I am running version 0.13.5.

The tab manager of chromium was showing 0.5 GB of memory usage for the vector.im tab.

The heap snapshot was 261 MB. I assume the rest of the 0.5GB is used internally by Chromium.

Attaching a screenshot of the highest memory consuming object.

riot-heap

@turt2live
Copy link
Member Author

I'm going to close this at risk of it being re-opened by someone on the team. Personally my memory usage has decreased and some other issues (#6212 and #3307 in particular).

@grahamperrin
Copy link

I haven't noticed a decrease …

2018-03-13 07 55 43

@turt2live
Copy link
Member Author

@grahamperrin /app is not updated to include the various improvements yet.

@grahamperrin
Copy link

Thanks @turt2live

With /develop it's fairly easy to have a colossal amount of virtual memory in use, for example from this:

2018-03-14 18 42 10

– to this (more than 34 G):

2018-03-14 19 26 23

– but that might be platform- and/or browser-specific,

@turt2live
Copy link
Member Author

@grahamperrin I highly recommend opening a new issue if you're seeing this as not improved. Keep in mind there's also #6212 and #3307 which have somewhat derailed into general performance problems.

@grahamperrin
Copy link

Yep, in a nutshell:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Performance P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants