Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregations: Show message action bar tooltips on hover #9716

Closed
jryans opened this issue May 14, 2019 · 2 comments
Closed

Aggregations: Show message action bar tooltips on hover #9716

jryans opened this issue May 14, 2019 · 2 comments

Comments

@jryans
Copy link
Collaborator

jryans commented May 14, 2019

Add an in-app tooltip on hover to show:

  • Emoji group "Agree or Disagree"
  • Emoji group "Like or Dislike"
  • "Add Reaction"
  • "Reply"
  • "Edit"
  • "More"
@nadonomy
Copy link
Contributor

@nadonomy nadonomy changed the title Reactions: Show emoji group name in tooltip on hover Reactions: Show message bar tooltips on hover May 15, 2019
@jryans jryans changed the title Reactions: Show message bar tooltips on hover Aggregations: Show message action bar tooltips on hover Jun 20, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 21, 2019
As part of reactions and editing work, we're adding a new style of tooltip that
allows interacting with the content of the tooltip.  `ContextualMenu` is closest
out of the things we have today, but it doesn't position in quite the way we
want and it's already quite complex.

To get started, let's first clone that to a new `InteractiveTooltip`.

Part of element-hq/element-web#9753
Part of element-hq/element-web#9716
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 21, 2019
This adjusts the positioning to work more the way we want:

* Tooltip is position on the top or bottom edge of the target depending on where
  space is available
* Tooltip and chevron are centered

In addition, more bits borrowed from `ContextualMenu` are not needed, so they
have been removed for simplicity.

Part of element-hq/element-web#9753
Part of element-hq/element-web#9716
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 21, 2019
This tweaks the tooltip to match the color, spacing, etc. seen in the designs.

Part of element-hq/element-web#9753
Part of element-hq/element-web#9716
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 21, 2019
We'd like to have a rounded point on the chevron for an extra level of polish.
This implements that look for browsers that support `clip-path`.

Part of element-hq/element-web#9716
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 21, 2019
This tweaks the tooltip to match the color, spacing, etc. seen in the designs.

Part of element-hq/element-web#9753
Part of element-hq/element-web#9716
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 21, 2019
We'd like to have a rounded point on the chevron for an extra level of polish.
This implements that look for browsers that support `clip-path`.

Part of element-hq/element-web#9716
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 24, 2019
This reworks the API the `InteractiveTooltip` component so that it's more
natural to use just like other React components. You can now supply the target
component as a child and the tooltip content as a prop.

In addition, this tweaks the interactivity to keep the tooltip on screen until
you move the mouse away from the tooltip and its target.

Part of element-hq/element-web#9753
Part of element-hq/element-web#9716
@lampholder lampholder added phase:4 and removed phase:3 labels Jul 2, 2019
@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2020

outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants