Set SUID bit on chrome-sandbox for Debian

[jryans]

This tweaks Linux packages for Riot to SUID chrome-sandbox after install. This
is required as of Electron 5 for certain distros, such as Debian.

This change has also been provided to electron-builder upstream, so ideally
they'll include it in the future and this becomes redundant.

Fixes #10509

[dbkr]

lgtm, although presumably this is duplicating the whole after-install file because the custom one replaces the standard one, so the comment means "delete this whole file" rather than, "remove this line"?

[jryans]

presumably this is duplicating the whole after-install file because the custom one replaces the standard one, so the comment means "delete this whole file" rather than, "remove this line"?

Yes, precisely. I'll tweak the comment to make that more obvious.

[batterystaples]

This issue prevents Riot from working when it is installed. Although the fix is simple (change the permissions of the chrome-sandbox file), many users who are not technical will install it, see that it doesn't work, and then give up. It also breaks things for users upgrading from an older version. This issue is significant enough that (in my view) it would justify making a special update to the packages in the repository just to fix this issue as soon as possible.

[jryans]

This issue prevents Riot from working when it is installed. Although the fix is simple (change the permissions of the chrome-sandbox file), many users who are not technical will install it, see that it doesn't work, and then give up. It also breaks things for users upgrading from an older version. This issue is significant enough that (in my view) it would justify making a special update to the packages in the repository just to fix this issue as soon as possible.

I don't understand if you are saying this change fixes such an issue (which it was meant to) or creates a new one... If an issue exists still, please open a new issue so we can investigate.

[batterystaples]

This change fixes an issue. However, the old, unfixed version is still in the official repositories, which was the point behind my comment.