Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-types #25256

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Update react-types #25256

merged 1 commit into from
Aug 24, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 2, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/react (source) 17.0.58 -> 17.0.64 age adoption passing confidence
@types/react-dom (source) 17.0.19 -> 17.0.20 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.


This change is marked as an internal change (Task), so will not be included in the changelog.

@renovate renovate bot requested a review from a team as a code owner May 2, 2023 11:06
@renovate renovate bot requested a review from germain-gg May 2, 2023 11:06
@renovate renovate bot added Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning labels May 2, 2023
@renovate renovate bot enabled auto-merge (squash) May 2, 2023 11:06
@renovate renovate bot changed the title Update dependency @types/react-dom to v17.0.20 Update react-types May 9, 2023
@renovate renovate bot force-pushed the renovate/react-types branch 2 times, most recently from 9383a65 to 6546b81 Compare June 1, 2023 16:20
@renovate renovate bot force-pushed the renovate/react-types branch 2 times, most recently from 31244b6 to f8de9e5 Compare June 16, 2023 16:57
@andybalaam
Copy link
Contributor

$ tsc --noEmit --jsx react
Error: matrix-react-sdk/node_modules/@types/react/index.d.ts(3077,14): error TS2300: Duplicate identifier 'LibraryManagedAttributes'.
Error: node_modules/@types/react/index.d.ts(3097,14): error TS2300: Duplicate identifier 'LibraryManagedAttributes'.
Error: node_modules/@types/react/index.d.ts(3168,13): error TS2717: Subsequent property declarations must have the same type.  Property 'link' must be of type 'DetailedHTMLProps<LinkHTMLAttributes<HTMLLinkElement>, HTMLLinkElement>', but here has type 'DetailedHTMLProps<LinkHTMLAttributes<HTMLLinkElement>, HTMLLinkElement>'.
Error: src/vector/app.tsx(45,1): error TS2322: Type 'typeof import("/home/runner/work/element-web/element-web/node_modules/@types/react/index")' is not assignable to type 'typeof React'.
  The types returned by 'lazy(...)' are incompatible between these types.

@renovate renovate bot merged commit 83b9406 into develop Aug 24, 2023
16 of 17 checks passed
@renovate renovate bot deleted the renovate/react-types branch August 24, 2023 13:34
andybalaam added a commit that referenced this pull request Aug 24, 2023
This reverts commit 83b9406.
because it breaks the build.
@richvdh
Copy link
Member

richvdh commented Aug 24, 2023

Reverted by #26048

andybalaam added a commit that referenced this pull request Aug 24, 2023
This reverts commit 83b9406.
because it breaks the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants