Separate out tasks for each merge in the Prepare Release script #28130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it's easier to see which one failed.
florianduros
approved these changes
Oct 1, 2024
t3chguy
reviewed
Oct 1, 2024
Comment on lines
88
to
89
| git config --global user.email "releases@riot.im" | ||
| git config --global user.name "RiotRobot" |
There was a problem hiding this comment.
Surely these don't need re-doing in each one given they all happen in the same env
There was a problem hiding this comment.
Ah, I wasn't 100% sure but now you mention it, yeah, of course it does.
t3chguy
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it's easier to see which one failed.
Checklist
public/exportedsymbols have accurate TSDoc documentation.