Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased the emoji size to 2em #3642

Closed
wants to merge 1 commit into from
Closed

Conversation

pavi
Copy link
Contributor

@pavi pavi commented Apr 18, 2017

Fixes #2890

Its a good idea to make the emojis look more visible and vibrant. Having them on the same size as the text makes them look very small. The one very good reason to have a bigger emoji is that an emoji expresents an expression which definitely conveys information more than one ASCII character.

largeremojisize

@lukebarnard1
Copy link
Contributor

FTR I think I've suggested 1.3em (below) in the past but to no avail. 2em seems a bit OTT.
2017-04-18-092113_384x114_scrot

@t3chguy
Copy link
Member

t3chguy commented Dec 27, 2017

Between #2890 (comment) and #3642 (comment) it looks like it should be increased, the amount by which though needs deciding - @ara4n / @lampholder any comments on this?

@4nd3r
Copy link
Contributor

4nd3r commented Nov 13, 2018

can we get this merged/done? please?

@jryans
Copy link
Collaborator

jryans commented Dec 17, 2018

@lampholder, I think it would be good to identify someone who can take a decision here. The general idea seems to have support, but we need to find the precise value to use. Should the decision maker be UX or someone else?

@lampholder
Copy link
Member

/me raises it with the product team (sorry for glacial progress)

@lampholder
Copy link
Member

And we have a conclusion! The delay was in me typing the conclusion in here btw - Matthew and Amandine responded right away.

The conclusion is: if it doesn't affect line spacing then go for it; if lines with emoji end up vertically wider (taller?) than lines without then nooooooo.

Our lines look like they could accommodate a 1.2 em emoji without altering spacing - what does a 2em emoji do?

@jryans
Copy link
Collaborator

jryans commented Mar 20, 2019

I would suggest changing the emoji size to px units (since the surrounding sizes seem to also be measured in px) and choose the largest value without growing the height of lines with vs. without emoji. (Be sure to check the measurements in all supported browsers.)

@turt2live
Copy link
Member

It looks like the file this needs has changed repos. Switching to pixels as @jryans mentions sounds like a good idea, Provided @lampholder's comment is addressed, I would see no problem with merging this over on the react-sdk side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve emojis heights
8 participants