Don't display security banner for unknown RecoveryState #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
bmarty
reviewed
Oct 2, 2024
| aSecureBackupRootState(backupState = BackupState.WAITING_FOR_SYNC), | ||
| aSecureBackupRootState(backupState = BackupState.CREATING), | ||
| aSecureBackupRootState(backupState = BackupState.RESUMING), | ||
| aSecureBackupRootState(backupState = BackupState.RESUMING), |
There was a problem hiding this comment.
Ooops, too many Cmd+D. Good catch!
| aSecureBackupRootState(backupState = BackupState.RESUMING), | ||
| aSecureBackupRootState(backupState = BackupState.DOWNLOADING), | ||
| aSecureBackupRootState(backupState = BackupState.DISABLING), | ||
| aSecureBackupRootState(backupState = BackupState.ENABLED), |
jmartinesp
force-pushed
the
fix/jme/do-not-display-security-banner-for-unknown-recovery-state
branch
from
2d8fe60
to
542c75b
Compare
jmartinesp
added
the
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
bmarty
approved these changes
Oct 2, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3579 +/- ##
========================================
Coverage 82.69% 82.70%
========================================
Files 1732 1732
Lines 40977 40982 +5
Branches 4964 4964
========================================
+ Hits 33886 33894 +8
+ Misses 5337 5333 -4
- Partials 1754 1755 +1 ☔ View full report in Codecov by Sentry. |
jmartinesp
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
bmarty
approved these changes
Oct 2, 2024
jmartinesp
deleted the
fix/jme/do-not-display-security-banner-for-unknown-recovery-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Motivation and context
@bnjbvr reported this bug found when the device couldn't correctly connect to the HS.
Screenshots / GIFs
In the PR.
Tests
The bug report says the device couldn't reach the server but the device had internet connectivity, so maybe block your HS address in your network temporarily or enable a proxy that doesn't connect to the HS.
Tested devices
Checklist