Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screenshot recording in CI #3607

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

jmartinesp
Copy link
Member

Content

Fix recording screenshots flow.

Motivation and context

The --no-configuration-cache was added in the wrong place, it's a gradle argument, not a jvm option.

Screenshots / GIFs

It somehow deleted some screenshots, which scares me a bit.

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label Oct 4, 2024
@jmartinesp jmartinesp requested a review from bmarty October 4, 2024 14:12
@jmartinesp jmartinesp requested a review from a team as a code owner October 4, 2024 14:12
Copy link
Contributor

github-actions bot commented Oct 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xwjGSw

Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (05a6a3b) to head (02a173f).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3607   +/-   ##
========================================
  Coverage    82.68%   82.68%           
========================================
  Files         1731     1731           
  Lines        41008    41008           
  Branches      4973     4973           
========================================
  Hits         33906    33906           
  Misses        5342     5342           
  Partials      1760     1760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp
Copy link
Member Author

The tests passed, so I guess deleting those screenshots was the right thing for the flow to do.

@bmarty
Copy link
Member

bmarty commented Oct 4, 2024

The tests passed, so I guess deleting those screenshots was the right thing for the flow to do.

Yes, the Preview has been removed here: https://github.com/element-hq/element-x-android/pull/3597/files#diff-50bc7833b8f4ad56f8bf8ac0ce9b0b5e055250aeb602115fa22666b858a4493f but since the screenshots has not been recorded on this PR, the screenshot files have not been removed.

@bmarty bmarty merged commit 2944879 into develop Oct 4, 2024
30 checks passed
@bmarty bmarty deleted the misc/jme/fix-screenshot-recording-in-ci branch October 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants