Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supportSlidingSync boolean. #3609

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 4, 2024

Note that this field was not used (read) anymore, so this is just cleaning up the code.

Context: #3605.

Note that this field was not used (read) anymore, so this is just cleaning up the code.
@bmarty bmarty requested a review from a team as a code owner October 4, 2024 14:58
@bmarty bmarty requested review from jmartinesp and removed request for a team October 4, 2024 14:58
@bmarty bmarty added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Misc For other changes labels Oct 4, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7Je2eu

Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (39d7084) to head (0018cce).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3609      +/-   ##
===========================================
- Coverage    82.68%   82.67%   -0.01%     
===========================================
  Files         1731     1730       -1     
  Lines        41008    40993      -15     
  Branches      4973     4971       -2     
===========================================
- Hits         33906    33892      -14     
  Misses        5342     5342              
+ Partials      1760     1759       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants