Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable notification filtering temporarily #1155

Closed
manuroe opened this issue Jun 25, 2023 · 4 comments · Fixed by #1162
Closed

Disable notification filtering temporarily #1155

manuroe opened this issue Jun 25, 2023 · 4 comments · Fixed by #1162
Assignees
Labels
X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue X-Release-Blocker

Comments

@manuroe
Copy link
Member

manuroe commented Jun 25, 2023

I am missing notifications including for messages in EX-Internal. EI displays them fine.

Doing more tests, I saw this pattern: if another user sends a message in a room I have not opened for a while, it is unlikely I will get a notification for this message. The problem is the same if the room is encrypted or not.
Once I open his room, I will receive further notifications.
Note that just seeing the room in the room list with the right last message is not enough to get the display of next notifications. I really need to open the timeline. This makes me think that we may have a problem with unknown room state to verify push rules correctly.

We should disable notification filtering for the release. It seems to complex to solve.

@manuroe manuroe changed the title Notifications can miss if the room has not been opened before in the app Disable notification filterering temporary Jun 26, 2023
@manuroe
Copy link
Member Author

manuroe commented Jun 26, 2023

I change the title to be more directive.
We should create an issue for further investigation after the release.

@manuroe
Copy link
Member Author

manuroe commented Jun 26, 2023

We should rollback https://github.com/matrix-org/matrix-rust-sdk/pull/2129/files#diff-f8239996bb4c6fc5d707bbdca5b86a9ebdfb87c07bc475d337969da9e17f5167R49-R52
I am missing notifications for DMs I am pretty sure I have the keys.

@ara4n ara4n changed the title Disable notification filterering temporary Disable notification filtering temporarily Jun 26, 2023
@Velin92
Copy link
Member

Velin92 commented Jun 26, 2023

keys or not they should be displayed... for now I am going to set a boolean in the Notification API in the rust SDK, that will decide if the check should be done or not, then I will make a new release ASAP

@Velin92 Velin92 added the X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue label Jun 26, 2023
@Velin92
Copy link
Member

Velin92 commented Jun 26, 2023

requires a new SDK release, created a branch to disable the filtering behaviour for now here:
matrix-org/matrix-rust-sdk#2145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue X-Release-Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants