Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push notifications are unreliable #1172

Closed
ara4n opened this issue Jun 27, 2023 · 3 comments · Fixed by #1412
Closed

Push notifications are unreliable #1172

ara4n opened this issue Jun 27, 2023 · 3 comments · Fixed by #1412
Assignees
@Velin92
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Jun 27, 2023

Steps to reproduce

  1. Run EI and EIX side by side
  2. Notice that often EI shows a notif which EIX doesn’t.

Apparently this is because EIX executes push rules clientside and if SS has never seen a given room, it fails to execute the rule.

However, SS should know all rooms via allrooms, so i’m confused how this breaks

Outcome

What did you expect?

reliable push

What happened instead?

push msgs getting dropped

Your phone model

No response

Operating system version

No response

Application version

254

Homeserver

No response

Will you send logs?

No
@Velin92 Velin92 added the X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue label Jun 27, 2023
@Velin92
Copy link
Member

Velin92 commented Jun 27, 2023

We just disabled the client side filtering given the push rules context of a room for now, until we find a way to have push rules work reliably with SS.
#1155

@kittykat kittykat added T-Defect S-Critical Prevents work, causes data loss and/or has no workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Notifications labels Jun 28, 2023
@manuroe
Copy link
Member

manuroe commented Jul 11, 2023

We need to revisit is when matrix-org/matrix-rust-sdk#2252 and all have landed.

@Velin92
Copy link
Member

Velin92 commented Jul 27, 2023

We are inserting an FF in nightly which should fix the issue in this PR:
#1412

Of course the solution is experimental that's way it's hidden behind an FF.

@Velin92 Velin92 linked a pull request Jul 27, 2023 that will close this issue
FF to enable filtering notifications by push rules #1412
Merged
@Velin92 Velin92 self-assigned this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Velin92 Velin92

Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FF to enable filtering notifications by push rules element-hq/element-x-ios
5 participants
@kittykat @ara4n @manuroe @Velin92 @VolkerJunginger