Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Compound close icon in favour of mishmash of x/close icons #108

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 1, 2024

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@@ -204,66 +204,3 @@ Please see LICENSE files in the repository root for full details.
mask-image: url("@vector-im/compound-design-tokens/icons/qr-code.svg");
}
}

.mx_UserMenu_CustomStatusSection {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This css is not used anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't used since we removed custom status labs over a year ago, but finally cleaning it up here as it was referencing an x/close svg and updating it felt moot

@t3chguy t3chguy added this pull request to the merge queue Oct 2, 2024
Merged via the queue into develop with commit 5d9996c Oct 2, 2024
27 checks passed
@t3chguy t3chguy deleted the t3chguy/consolidate-x branch October 2, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants