-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timezone to user profile #20
Conversation
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
And automatically refresh the timezone every minute.
…ng to the timezone field.
|
src/i18n/strings/pl.json
Outdated
@@ -1841,10 +1841,25 @@ | |||
"files_button": "Pliki", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes came from 33c9c04, I don't know whether I should remove them from my commit list to make the CI pass or just ignore it?
@dbkr PR ended up moving here, if you wouldn't mind a re-review (sorry!) |
Looks good. For the end to end tests, you'll just need to run the command to update the screenshot file. For sonarcloud coverage... it's whining because the code to update / delete the timezone is not tested, which feels legit I think. Any chance of a test for this? |
@dbkr New tests added and screenshots fixed, I think this is ready for you to look at. |
Quality Gate passedIssues Measures |
(I have CLA'd, but it seems to think I have not) |
Migrated from matrix-org/matrix-react-sdk#12967
Implements MSC4175
Depends on matrix-org/matrix-js-sdk#4391
Design provided at https://www.figma.com/design/gpxHFDTNK796n84r1ZxYG2?node-id=1360-28954#941702635
This provides a basic presentation of a user's current time & timezone on their profile. It also adds a setting to allow publishing the time.
Timezone in user profile
Timezone publish setting
Checklist
public
/exported
symbols have accurate TSDoc documentation.Signed-off-by: Will Hunt cla@half-shot.uk