Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant Element Call widget capabilities for "raise hand" feature #82

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

AndrewFerr
Copy link
Member

This allows the widget to send and receive event types used by the "raise hand" feature (element-hq/element-call#2542) without prompting the user to grant the capabilities to do so.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

This allows the widget to send and receive event types used by the
"raise hand" feature (element-hq/element-call#2542) without prompting
the user to grant the capabilities to do so.
@AndrewFerr
Copy link
Member Author

The failing Jest test is test/components/structures/MatrixChat-test.tsx, but that passes for me locally, so I'm not sure what's going on in CI.

@dbkr dbkr added this pull request to the merge queue Sep 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 23, 2024
@dbkr dbkr added this pull request to the merge queue Sep 23, 2024
Merged via the queue into element-hq:develop with commit ef1d4f6 Sep 23, 2024
31 of 32 checks passed
@AndrewFerr AndrewFerr deleted the call-widget-raise-hand branch September 24, 2024 13:04
@renovate renovate bot mentioned this pull request Oct 4, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants