Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateManager: clean up update_cache #2196

Merged
merged 2 commits into from
Jul 2, 2024
Merged

UpdateManager: clean up update_cache #2196

merged 2 commits into from
Jul 2, 2024

Conversation

danirabbit
Copy link
Member

Review with hide whitespace

  • Return early
  • Less nesting
  • Don't check the same things over and over
  • Use list of updates from the updates liststore, not getting a whole new list from flatpak backend

@danirabbit danirabbit requested a review from a team June 29, 2024 20:07
@zeebok zeebok merged commit 0fc1514 into main Jul 2, 2024
2 of 4 checks passed
@zeebok zeebok deleted the danirabbit/updatemanager-cachecleanups branch July 2, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok