Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppListUpdateView: DRY Update All #2199

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 2, 2024

UpdateManager:

  • Make update_all its own function that is cancellable
  • Make sure to use class-wide cancellable for auto updates

AppListUpdateView:

  • Use update_all function from update_manager
  • Make sure to set action buttons back to sensitive if update_all is canceled or errors

@danirabbit danirabbit requested a review from a team July 2, 2024 23:09
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure what the action sensitivity does but things appear to work as normal

@danirabbit
Copy link
Member Author

@zeebok if you use the "Update All" button in the interface it'll make all the update buttons insensitive so you can't just keep clicking update over and over. It won't have any affect if the update was triggered automatically however. Still needs more work to handle that

@zeebok
Copy link
Contributor

zeebok commented Jul 3, 2024

@danirabbit Gotcha, I thought maybe it was making all buttons insensitive until it finished looking for updates or something, but wasn't seeing that happen

@zeebok
Copy link
Contributor

zeebok commented Jul 3, 2024

Can confirm that is the behavior, and is cancellable

@danirabbit danirabbit merged commit e31bf55 into main Jul 3, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/appupdatelistview-dryupdateall branch July 3, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants