Add support for new developer id #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryonakano
reviewed
Aug 7, 2024
Yes. It is still a draft because I want some feedback from your part about the questions on this PR description. 😃 |
ryonakano
reviewed
Aug 7, 2024
This will make AppCenter not to find any other application if the developer has one with a developer ID defined in its metadata!
ryonakano
reviewed
Aug 9, 2024
ryonakano
reviewed
Aug 13, 2024
ryonakano
approved these changes
Aug 20, 2024
|
Woah! This is the first time I contribute to an OS! Thanks for accepting my contribution 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first approach to support the new developer id (closes #2102). Although I added a new property to
Package.valapopulating that id, it is really uncommon that this info is available.The "More apps from this developer" feature is kind of broken right now because of this... Should I search by author name like before in case no more apps are found?
I left some
warninglogs just to check the realted properties to this functionality inFlatpakBackend.vala.