Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale cards based on display size #374

Closed
wants to merge 6 commits into from
Closed

Conversation

cassidyjames
Copy link
Contributor

@cassidyjames cassidyjames commented Oct 28, 2019

Fixes #303

Right now this only scales the wallpaper on the card to be a quarter of the display size (which is roughly what the original mockup had).

Notes:

  • The wallpaper on the card will match the display aspect ratio; before, it was always 2:1
  • Fonts or anything else are not scaled any differently
  • I'm not sure how this works on multiple differently-sized displays attached to one machine
  • Right now (WIP) it's getting the display size each time to use it, need to DRY that out
  • Setting the size to ¼ the display size means you can usually see 1½ users on either side, for a total of 3–5 (at least partially) visible users depending on which user you're scrolled to.

@cassidyjames
Copy link
Contributor Author

1024×768 (smallest supported resolution)

1024×768

1920×1080 (same layout for 4K HiDPI)

1920×1080

2560×1440 (common on big ol' 27" displays)

2560×1440

@cassidyjames
Copy link
Contributor Author

It looks like the scale in the construct block is not correct, but always returns 1. The means the cards are twice as big as they should be in each dimension.

@ghost
Copy link

ghost commented Mar 4, 2020

So, a question about setting this. I run in 1600x900, with the "Larger" setting for text, as I have vision problems.

Would or should I be able to separately set the lightdm resolution to 1024x768, if only to make the user cards and login box large enough for me to see comfortably?

@cassidyjames
Copy link
Contributor Author

@callieg that's not really related to this branch, as this does not affect the text size; it just makes the card itself (and wallpaper) fill up more space relative to the display.

But to answer your question, I don't believe resolution is carried over from the user session, and there's not currently a graphical way to set a manual resolution on the greeter. However, the font scaling should probably be added as a setting that gets respected on the greeter as well.

@ghost
Copy link

ghost commented Mar 4, 2020

And Cassidy, this is why I love you guys. I am no programmer, not even remotely, I am just an enthusiastic user, but you did actually take the time to respond to this.

And you should know that it is greatly appreciated.

@BAProductions
Copy link

BAProductions commented Jul 27, 2020

Not needed have look at my fix #65 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase user preview size on large screens
2 participants