Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an InfoBar if attachments include an ICS file #915

Merged
merged 5 commits into from
Jul 20, 2023

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jun 29, 2023

  • Show an InfoBar that tells the user the message comes with a calendar event and allows the user to open it right away
  • Also when opening attachments without saving them their temp file will now be in a separate directory within the temp dir so that it can keep its original name to avoid strange names like AZAY61-calendar.ics
  • Suggestion for better phrasing are always appreciated :)

@leolost2605 leolost2605 changed the title Shows an InfoBar if attachments include an ICS file Show an InfoBar if attachments include an ICS file Jun 29, 2023
@leolost2605 leolost2605 requested a review from a team June 29, 2023 12:27
@danirabbit danirabbit mentioned this pull request Jul 13, 2023
6 tasks
@zeebok
Copy link
Contributor

zeebok commented Jul 20, 2023

Code looks good. Not sure what is the cause of the issue but if I use the button to open in calendar without Calendar already running, it doesn't seem to work. I'll see the icon for the app but no window ever appears. Using the button when calendar is running works like a charm.

If that is something that can't be fixed here I will just approve.

Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug I saw seems to be Calendar's issue so this is approved

@zeebok zeebok merged commit 9cbece9 into master Jul 20, 2023
3 checks passed
@zeebok zeebok deleted the show-calendar-event branch July 20, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants