Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the actual recipients of a message as sender when replying or forwarding #956

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Use the actual recipients of a message as sender when replying or forwarding #956

merged 7 commits into from
Nov 6, 2023

Conversation

leolost2605
Copy link
Member

This fixes an issue that occurred when replying to a message received by an alias. Then the pre-selected sender would be the main address.

@leolost2605 leolost2605 requested a review from a team September 9, 2023 18:50
@leolost2605 leolost2605 mentioned this pull request Sep 9, 2023
Closed
danirabbit
danirabbit reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand what this is doing, but can you add a comment in the code about what/why this does so that someone doesn't come along later and remove it thinking it's superfluous 😅

@leolost2605
Copy link
Member Author

I've added some comments and I hope they are understandable but tell me if they are unclear :)

danirabbit
danirabbit approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@danirabbit danirabbit enabled auto-merge (squash) November 6, 2023 18:20
@danirabbit danirabbit merged commit 6cc2f51 into master Nov 6, 2023
3 checks passed
@danirabbit danirabbit deleted the composer-use-recipients branch November 6, 2023 18:32
@novakwh novakwh mentioned this pull request Feb 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leolost2605 @danirabbit