Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some attachments not showing up #958

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Fix some attachments not showing up #958

merged 4 commits into from
Nov 6, 2023

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Sep 10, 2023

Fix some attachments not showing up.

Tries to fix #957

Only for reference if this doesn't work: the evolution way of getting whether a part is an attachment is (I think) found here

@leolost2605
Copy link
Member Author

@wout could you maybe test whether this fixes your issue?
Unfortunately I currently don't have any attachments that don't load

@wout
Copy link
Sponsor

wout commented Sep 11, 2023

I'll try to test this asap, I'm swamped at the moment. I've sent you the email in question, maybe it helps to test the issue?

@leolost2605
Copy link
Member Author

I'll try to test this asap, I'm swamped at the moment

No worries, test when you've got enough time :)

I've sent you the email in question, maybe it helps to test the issue?

Unfortunately the attachment didn't come along probably for the same reason it doesn't show up for you :(

@wout
Copy link
Sponsor

wout commented Sep 11, 2023

Okay, I've forwarded you the mail from Mailspring. In Mail, the attachment icon is present at the top left of the email, but the attachment is not visible at the bottom of the mail.

@leolost2605
Copy link
Member Author

Unfortunately the attachment showed up in master and this branch for me, maybe Mailspring changed the format or something... 🤷

@leolost2605
Copy link
Member Author

Maybe we can just merge this because I don't think it will introduce any regression but it might fix the problem 🤷

@leolost2605 leolost2605 requested a review from a team November 5, 2023 10:57
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm attachments still show up here so :shipit:

@danirabbit danirabbit merged commit 9c40f9b into master Nov 6, 2023
3 checks passed
@danirabbit danirabbit deleted the fix-attachments branch November 6, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't download attachment from email
3 participants