-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some attachments not showing up #958
Conversation
@wout could you maybe test whether this fixes your issue? |
I'll try to test this asap, I'm swamped at the moment. I've sent you the email in question, maybe it helps to test the issue? |
No worries, test when you've got enough time :)
Unfortunately the attachment didn't come along probably for the same reason it doesn't show up for you :( |
Okay, I've forwarded you the mail from Mailspring. In Mail, the attachment icon is present at the top left of the email, but the attachment is not visible at the bottom of the mail. |
Unfortunately the attachment showed up in master and this branch for me, maybe Mailspring changed the format or something... 🤷 |
Maybe we can just merge this because I don't think it will introduce any regression but it might fix the problem 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm attachments still show up here so
Fix some attachments not showing up.
Tries to fix #957
Only for reference if this doesn't work: the evolution way of getting whether a part is an attachment is (I think) found here