Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env.php configuration and introduce Credit_Client Factory #30

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

mwr
Copy link
Contributor

@mwr mwr commented Dec 10, 2018

This pull request will

  • add env.php configuration for elgentos_largeconfigproducts
  • use env.php configuration to create the Credis_Client
  • fallback to the Settings stored in store config (core_config_data)
  • refactor instantiation of Credis_Client to custom Factory

This way it is possible to have a custom configuration in you env.php, looking something like this:

  'cache' =>
  array (
    'frontend' =>
    array (
      'elgentos_largeconfigproducts' => [
        'backend' => 'Cm_Cache_Backend_Redis',
        'backend_options' => [
            'server' => '__REDIS_HOST__',
            'port' => '__REDIS_PORT__',
            'password' => '__REDIS_PASSWORD__',
            'persistent' => '',
            'database' => '__REDIS_DATABASE__',
        ]
      ],

The recently introduced way using the store-configuration in core_config_data will be used as a fallback mechanism to preserve backwards compatibility.

- add env.php configuration for elgentos_largeconfigproducts
- use this configuration to create the Credis_Client
- fallback to Settings from store config (core_config_data)
- refactor instantiation of Credis_Client to custom Factory
@simonmaass
Copy link

would be great!

@peterjaap
Copy link
Contributor

LGTM!

@peterjaap peterjaap merged commit a523fe7 into elgentos:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants