WIP: Serialization #27
Conversation
…the serialized code
There was a problem hiding this comment.
Looks already really good to me!
Did you check out the 'Validators' and 'Quickfixes'?
I think a combination of your solution and validators would be great, because then we could provide inline warnings and quick fix suggestions and additionally allow users to fix their diagrams in place.
For the transformation it would also be so much easier if we had less rules in XText, which we need to handle.
Maybe we can keep this PR on hold while investigating the other solution so we can do the easy transformation first and then adopt your rules afterwards?
What do you think?
There was a problem hiding this comment.
Good job investigating and implementing a proof of concept. This PR shows that using Serialization is a viable method of creating a file that is most compatible with PlantUML as well as UML.
However in my opinion this adds a lot of complexity regarding Xtext rules and it is not immediately obvious to me how to add future compatibility fixes in a sustainable way.
This approach feels quite heavyweight and may be too complex and overpowered for now, otherwise correct me if I'm wrong.
|
The rules that where changed in PlantUML.xtext by this merge request conflict the rules of the merge request regarding the cross-references! We need to consider this before merging one or the other. Especially the distinction between Quoted- and Unquoted-X seems a bit heavyweight for me. Can you take a look at the branch cross-references where I managed to allow Quoted and Unqoted participant mentions in messages by Parsing the Cross-Reference with the Role ParticipantMention and extracting the reference without the quotes afterwards with a value converter? Also im not quite sure if we can safely remove the "returns Participant" part at the different Participant Definitions. Correct me if im wrong! |
Die Serialisierung funktioniert und im eclipse editor wird automatisch eine neue Datei angelegt, welche den serialisierten Code enthält. Im test Ordner befinden sich zwei Tests für die Serialisierung. Es wäre super wenn ihr es euch anschauen könntet.