Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new form features #161

Merged
merged 20 commits into from
Nov 11, 2023
Merged

feat: new form features #161

merged 20 commits into from
Nov 11, 2023

Conversation

SalihuDickson
Copy link
Contributor

@SalihuDickson SalihuDickson commented Nov 8, 2023 •
edited
Loading

Description

Adds new features to the form component

Fixes #168

Checklist

  • My code follows the contributing guidelines of this project.
  • I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • I have updated the user-facing documentation to describe any new or changed behavior.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have not reduced the existing code coverage.

Comments

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c402c0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloud-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2023 7:41pm

@SalihuDickson SalihuDickson changed the title Design/feat feat: new form features Nov 8, 2023
anuragxxd
anuragxxd previously approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@anuragxxd anuragxxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor fixes though.

packages/ecc-utils-design/src/components/form/form.ts Show resolved Hide resolved
packages/ecc-utils-design/src/components/form/form.ts Outdated Show resolved Hide resolved
@SalihuDickson SalihuDickson mentioned this pull request Nov 11, 2023
Closed
anuragxxd
anuragxxd reviewed Nov 11, 2023
View reviewed changes
Copy link
Member

@anuragxxd anuragxxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in the docs example can you remove the switchOptions as it will be removed after this PR & add the default value of switch to true in one of the example!

packages/ecc-utils-design/src/components/form/form.ts Outdated Show resolved Hide resolved
@SalihuDickson SalihuDickson merged commit cc1c8cc into main Nov 11, 2023
7 checks passed
@SalihuDickson SalihuDickson deleted the design/feat branch November 11, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuragxxd anuragxxd anuragxxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add multiple file inputs in design/form component
2 participants
@SalihuDickson @anuragxxd