Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wes): add dropdown for workflow type/version #247

Conversation

Chaitanya674
Copy link

Description

added a dropdown in design and made a function in ecc-client-lit-ga4gh-wes which set the options for the workflow type and workflow version but the function is having trouble in accessing the form-data so commented it .please uncomment the function first in order to check.

Fix #180

Checklist

  • [*] My code follows the contributing guidelines of this project.
  • [*] I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
  • [*] I have performed a self-review of my own code.
  • [*] I have commented my code in hard-to-understand areas.
  • I have updated the user-facing documentation to describe any new or changed behavior.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • [*] I have not reduced the existing code coverage.

Comments

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: 0257a87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloud-components ❌ Failed (Inspect) Mar 10, 2024 2:03pm

@uniqueg uniqueg changed the title feat(wes-create-run.ts): added a dropdown to lit-wes feat(wes): add dropdown for workflow type selection Mar 6, 2024
@uniqueg uniqueg changed the title feat(wes): add dropdown for workflow type selection feat(wes): add dropdown for workflow type/version Mar 6, 2024
@JaeAeich
Copy link
Contributor

JaeAeich commented Mar 8, 2024

For the dev demo, change remove baseURL from the component, this will force component to use default URL since you might not have the dev of backend setup on you system. Also please check your code, it has some logical errors maybe check the output of the API first 😅 , also we usually define the API in API folder. It would be good to create the fetch fucn there and then import it.

Chaitanya674 added a commit to Chaitanya674/cloud-components that referenced this pull request Mar 10, 2024
BREAKING CHANGE: this compoenent may not work if the connectedCallback() is not uncommented rest of
the part I have checked there is a getFromData function created in order get the form data to set
version according to the selected type.

re elixir-cloud-aai#247
@Chaitanya674 Chaitanya674 force-pushed the Chaitanya674/dropdown-component branch from 37f9b3f to 37ce888 Compare March 10, 2024 14:01
@Chaitanya674 Chaitanya674 force-pushed the Chaitanya674/dropdown-component branch from 37ce888 to 0257a87 Compare March 10, 2024 14:02
@Chaitanya674 Chaitanya674 deleted the Chaitanya674/dropdown-component branch March 10, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(wes): enums for workflow type & type versions
2 participants