refactor: upgrade FOCA & major app rewrite #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvarin
reviewed
Nov 14, 2022
Co-authored-by: Alex Kanitz <alexander.kanitz@alumni.ethz.ch>
|
Can we merge this? Current default branch does not pass the tests, the image used in the docker file does not have any repository available. |
uniqueg
changed the title
uniqueg
changed the title
uniqueg
changed the title
uniqueg
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Excellent work!
Of course, there's the cwl-tes import issue that should prevent the app from processing any workflows. But given that the HEAD commit is anyway broken and this PR is already gigantic, I think we can merge this now.
There are probably a bunch of other small issues as well, but overall it looks very good, I think. Again, time to merge and then figure out issues later on and get the app back working 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Excess boilerplate code was removed and replaced by FOCA's latest version.
Fixes #153