Fixing bug #256
Merged
Fixing bug #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request addresses a bug in the 'update-config-map.sh' script. The change corrects a syntax error in the command that checks for the presence of 'yq'. The fix ensures that the script exits properly if 'yq' is not found. Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @lvarin - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Syntax error in the command substitution. (link)
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -43,7 +43,7 @@ echo "Current Kubernetes namespace: $NAMESPACE"; echo | |||
|
|
|||
| echo " * Getting current default configuration" | |||
|
|
|||
| command -V yq || echo "yq not found, exiting"; exit 6 | |||
| command -V yq || { echo "yq not found, exiting"; exit 6} | |||
There was a problem hiding this comment.
issue (bug_risk): Syntax error in the command substitution.
The closing brace '}' should be followed by a semicolon to properly terminate the command block. The corrected line should be: command -V yq || { echo "yq not found, exiting"; exit 6; }.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.
Details
Please provide enough information so that others can review your pull request. Give a brief summary of the motivation. Refer to the corresponding issue/s with
#XXXXfor more information.Testing
Write the appropriate unit and integration tests, if applicable. Make sure these and all other tests pass.
Documentation
Please document your changes and test cases in the appropriate places, if applicable.
Style
Make sure your changes adhere to the coding/documentation style used throughout the project.
Closing issues
If your changes fix any issue/s, put
closes #XXXXin your comment to auto-close it/them.Credit
Add your credentials to the list of contributors once your pull request was merged.
Summary by Sourcery
This pull request addresses a syntax error in the update-config-map.sh script, ensuring the script exits correctly when the 'yq' command is not found.