Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api-docs JSON example #30

Merged
merged 5 commits into from
Jan 24, 2023

Conversation

lvarin
Copy link
Contributor

@lvarin lvarin commented Dec 23, 2021

The api-docs json definition of the API was not passing the JSON parsing. One of the examples (in colunm ~1580, with text us-west-1), needed quotes,

@lvarin lvarin force-pushed the fix-api-docs-example branch 3 times, most recently from 703f76f to fe35522 Compare December 27, 2021 09:39
The api-docs json definition of the API was not passing the JSON parsing. One of the examples (in colunm ~1580, with text us-west-1), needed quotes
@uniqueg uniqueg changed the title Fix api-docs JSON example fix: api-docs JSON example Jan 18, 2023
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tend to be in favor of merging 🙈😆

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 55.52% // Head: 55.47% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (fc72d38) compared to base (27a1323).
Patch coverage: 60.56% of modified lines in pull request are covered.

❗ Current head fc72d38 differs from pull request most recent head db5a7b9. Consider uploading reports for the commit db5a7b9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   55.52%   55.47%   -0.05%     
==========================================
  Files          64       64              
  Lines        2064     2118      +54     
  Branches      217      231      +14     
==========================================
+ Hits         1146     1175      +29     
- Misses        787      803      +16     
- Partials      131      140       +9     
Impacted Files Coverage Δ
...ain/java/uk/ac/ebi/tsc/tesk/config/GsonConfig.java 100.00% <ø> (ø)
...sc/tesk/config/swagger/OAuth2ClientProperties.java 88.88% <ø> (ø)
...bi/tsc/tesk/k8s/config/KubernetesClientConfig.java 92.85% <ø> (ø)
.../uk/ac/ebi/tsc/tesk/k8s/constant/K8sConstants.java 85.71% <ø> (ø)
...i/tsc/tesk/k8s/convert/ExecutorCommandWrapper.java 100.00% <ø> (ø)
.../tsc/tesk/k8s/convert/TaskmasterEnvProperties.java 91.66% <ø> (ø)
.../java/uk/ac/ebi/tsc/tesk/k8s/convert/data/Job.java 88.88% <ø> (ø)
.../tsc/tesk/k8s/convert/data/SingleTaskStrategy.java 90.90% <ø> (ø)
...java/uk/ac/ebi/tsc/tesk/k8s/convert/data/Task.java 93.54% <ø> (ø)
.../ac/ebi/tsc/tesk/k8s/convert/data/TaskBuilder.java 100.00% <ø> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lvarin lvarin merged commit df6446f into elixir-cloud-aai:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants