-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: api-docs JSON example #30
Conversation
703f76f
to
fe35522
Compare
The api-docs json definition of the API was not passing the JSON parsing. One of the examples (in colunm ~1580, with text us-west-1), needed quotes
fe35522
to
f7d61b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tend to be in favor of merging 🙈😆
Codecov ReportBase: 55.52% // Head: 55.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 55.52% 55.47% -0.05%
==========================================
Files 64 64
Lines 2064 2118 +54
Branches 217 231 +14
==========================================
+ Hits 1146 1175 +29
- Misses 787 803 +16
- Partials 131 140 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The api-docs json definition of the API was not passing the JSON parsing. One of the examples (in colunm ~1580, with text us-west-1), needed quotes,