Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elixir 1.17 warnings #368

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Fix elixir 1.17 warnings #368

merged 5 commits into from
Jun 21, 2024

Conversation

hypno2000
Copy link
Contributor

@hypno2000 hypno2000 commented Jun 9, 2024

Fix these warnings in elixir 1.17:

warning: using map.field notation (without parentheses) to invoke function Module.__rpc_calls__() is deprecated, you must add parentheses instead: remote.function()

Right now all projects that depend on grpc generate warnings on user project (because the warnings are generated in the macros that user projects are calling), which means it breaks user projects CI's in elixir 1.17 that use --warnings-as-errors

@hypno2000
Copy link
Contributor Author

Is there anything i can do from my side to help it getting merged?

@sleipnir sleipnir merged commit 4526427 into elixir-grpc:master Jun 21, 2024
8 checks passed
@sleipnir
Copy link
Collaborator

Thank you @hypno2000 sorry for the late answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants