G7 #140
Open
G7 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
ellemouton
force-pushed
the
g7
branch
8 times, most recently
from
ad218b6
to
3cea90d
Compare
ellemouton
force-pushed
the
g7
branch
3 times, most recently
from
f216c0a
to
46d4776
Compare
Along the way we refactor the test to eliminate some unnecessary line length.
…tion In this commit, we bring the timeout resolver more in line with the success resolver by using the sweeper to handle the HTLC offered remote timeout outputs. These are outputs that we can sweep directly from the remote party's commitment transaction when they broadcast their version of the commitment transaction. With this change, we slim down the scope slightly by only doing this for anchor channels. Non-anchor channels will continue to use the utxonursery for this output type for now.
The name in the verify-install.sh and the PGP key file need to be the same.
There are some links in this document that cause issues for pull request [lightningnetwork#670](lightninglabs/docs.lightning.engineering#670) in the Builder's Guide Repo.
This pull request changes an outdated link as it causes issue [lightningnetwork#670](lightninglabs/docs.lightning.engineering#670). The document is mirrored on the Builder's Guide repo
I updated two `gprc.io` resources. Additionally the article on [javascript protocol buffers](https://developers.google.com/protocol-buffers/docs/reference/javascript-generated) is no longer available. I believe [this article](https://protobuf.dev/protobuf-javascript/) replaces it and that Google has moved the protobuf documentation to another domain.
Signed-off-by: xixishidibei <xixishidibei@outlook.com>
Update links in javascript.md
Update http to https in c#.md
Fix links to resolve issue in Builder's Guide (https and redirect)
Documentation how to sign a LND/LNCLI release by a developer
This struct will house all the information we'll need to do a class of custom channels that relies primarily on adding additional items to the tapscript root of the HTLC/commitment/funding outputs.
With this commit, we'll now populate all the custom channel information within the OpenChannel and ChannelCommitment structs.
In this commit, we make a new `AuxFundingController` interface capable of processing messages off the wire. In addition, we can use it to abstract away details w.r.t how we obtain a `AuxFundingDesc` for a given channel. We'll now use this whenever we get a channel funding request, to make sure we pass along the custom state that a channel may require.
If this is a taproot channel, then we'll return the internal key which'll be useful to callers.
We also add a new assertion to the itests to ensure the field is being properly set.
In this commit, we pass the MessageSignerRing around in places where Schnorr signing will be needed to sign Gossip 1.75 messages.
Update the ChannelUpdate modifiers to use the lnwire.ChannelUpdate interface instead of *lnwire.ChannelUpdate1.
...interface instead of ChannelUpdate1.
In the IsKeepAlive and IsStaleEdgePolicy functions
So that a start block and end block can also be passed in.
In preparation for the signing flow for the ChannelAnnouncement2 message, we add functionality here to store the bitcoin and node nonces sent to us by our peer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.