-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match Ancestry.com source by _APID, not SOUR #324
Comments
Maybe with this SO about cmp.equals() for structs? |
Looks like this is the function ( |
Tag.Is(Tag) is here, but it doesn't look like that is used to exclude it from the diff. |
Found where the code should go, in SimpleNode.Equals(). You may want to add a command line param to enable or disable this. |
And how would you address the difference in which ancestry and Geni output dates? These two should be equivalent, not similar (I want to even keep matches that are 99.99% similar, but not this).
|
For cases like this, we need to add a some custom comparison for It might make the most sense to add a
These are still not exactly equal, but they are close enough to give a high similarity number that should be over the "equals" threshold. |
Running
gedcom diff -hide-equal
on two Ancestry gedcoms yields the same profiles with the same sources as 99.58% similar - but different, because their sources have different SOUR tags but the same _APID tags (which is the UID of Ancestry sources). Is there a way to specify to check source equality by _APID? If not from the CLI, where in code would I do this? All I want is that if two sources are the same, that they don't appear in the HTML output diff (and if they were the only diff, that the individual is not included in the diff).The text was updated successfully, but these errors were encountered: