Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to check custom header when receiving http endpoint request #4230

Conversation

tanelkuhi
Copy link

@tanelkuhi tanelkuhi commented Jul 12, 2023

For HttpEndpoint activity we have to have the previous authorization work in parallel with the now new check for plain header (ApiKey or something like that). I feel like there could be a better solution, so I am open to suggestions.

@sfmskywalker
Copy link
Member

A more elegant approach might be to associate "http filters" with a given HTTP request, making it more modular and configurable. This could be achieved by examining how API gateways manage request filtering. However, I'm comfortable accepting this PR as it stands, since it introduces optional features that will be useful for others who may be seeking the same solution.

@sfmskywalker sfmskywalker merged commit 4a6872d into elsa-workflows:master Aug 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants