Reduce ambiguity in *.js file extension in addon-root files by explicitly mentioning cjs or mjs #103
Conversation
| @@ -1,4 +1,4 @@ | |||
| <% if (typescript) { %>import typescript from 'rollup-plugin-ts';<% } else { %>import babel from '@rollup/plugin-babel';<% } %> | |||
| <% if (typescript) { %>import typescript from 'rollup-plugin-ts';<% } else { %>import { babel } from '@rollup/plugin-babel';<% } %> | |||
There was a problem hiding this comment.
Was this a real bug, or why this change?
There was a problem hiding this comment.
even though the package exports both default and named babel, some tooling requires the named export.
I forget now, but I'd rather go with what's stable for all environments, than using default "just cause".
I should really have written this down when I encountered it :(
I don't think we can -- something to do with ember-auto-import, I think? |
|
We think type:module support might already be working now due to embroider-build/ember-auto-import#544 |
This is partially w/r/t to linters being able to correctly match based on package.json settings, but partially because we currently rely on
typeto not be set at all in package.json, which implies that.jsis common-js, but that's not always true.For tooling sanity, this PR makes the cjs files .cjs, and the rollup file .mjs
This work came out of CrowdStrike/ember-toucan-core#9
Which, I'd normally say it isn't fair to change things just because of one person's lint configs, but the ambiguity in v2 addons right now is def troublesome