Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempted to resolve did-insert, which was expected to be a modifier, but nothing was found #1514

Closed
simonihmig opened this issue Jul 4, 2023 · 1 comment · Fixed by #1560
Closed

Attempted to resolve did-insert, which was expected to be a modifier, but nothing was found #1514

simonihmig opened this issue Jul 4, 2023 · 1 comment · Fixed by #1560
Labels
bug Something isn't working has reproduction

Comments

@simonihmig
Copy link
Collaborator

Seeing this error pop up (in this PR, second 70c78db commit).

I am using @ember/render-modifiers (which I probably should get rid off, but they should work nevertheless), but they don't seem to be included into the build. This does get "fixed" by downgrading to Embroider 2!
@mansona mansona added bug Something isn't working has reproduction labels Jul 5, 2023
@mansona
Copy link
Member

mansona commented Jul 5, 2023

I just confirmed this issue and I have a fix for it (but it is not a good permanent solution)

Essentially this is the same case that I brought up in the embroider meeting yesterday, the components that are being re-exported via the app exports are depending on something that is in the dependencies of the addon. This doesn't work and we agreed that this should be considered a bug from the embroider perspective

The "fix" that I was talking about was to move @ember/render-modifiers to be a peer-dependency of the addon and install it directly in the app, but that isn't something that you probably want to ship and we should just fix it upstream

@ynotdraw ynotdraw mentioned this issue Jul 11, 2023
Open
ef4 added a commit that referenced this issue Jul 25, 2023
@ef4
Fix implicit-modules in v2 addons
be76613 
Fixes #1514

The bug was introduced in #1536 when we refactored how implicit-modules get included.

A v2 addon with a v1 addon dependency would miss including implicit-modules for that v1 addon.

This code needed to explicitly ask for the moved copy of a dependency, in case the dependency had moved.
ef4 added a commit that referenced this issue Jul 25, 2023
@ef4
Fix rewritten package cache encapsulation
de71561 
Fixes #1514

A v2 addon with a v1 addon dependency was not resolving its dependencies correctly, in two places.
 - in virtual-content.ts where we emit implicit-modules
 - in compat-app-builder.ts when doing partitionEngines

The fix to both is adjusting the meaning of RewrittenPackageCache so
that it always automatically provides packages that see moved
dependencies, even when a given package *itself* has not moved (because
it's a v2 addon).
ef4 added a commit that referenced this issue Jul 25, 2023
@ef4
Fix rewritten package cache encapsulation
66f0f5a 
Fixes #1514

A v2 addon with a v1 addon dependency was not resolving its dependencies correctly, in two places.
 - in virtual-content.ts where we emit implicit-modules
 - in compat-app-builder.ts when doing partitionEngines

The fix to both is adjusting the meaning of RewrittenPackageCache so
that it always automatically provides packages that see moved
dependencies, even when a given package *itself* has not moved (because
it's a v2 addon).
@ef4 ef4 mentioned this issue Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working has reproduction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rewritten package cache encapsulation embroider-build/embroider
2 participants
@mansona @simonihmig