don't run CI for all branches starting with v #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
void-mAlex
approved these changes
Nov 8, 2023
|
should we do the same for tags? |
No i think we're fine, most of the time we're not going to "accidentally" create a tag that starts with v but isn't in the format of vX.Y.Z 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that CI was originally running twice for #1653 because the branch name was
virtual-implicit-modules🤦This PR makes sure that branch pushes only run if it starts with a
vthat is immediately followed by at least one number, it's not a perfect solution but it's a lot better than what we had 😂