fix the release-stable CI job #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
fix-release-stable
branch
from
db53c7c
to
720c10f
Compare
NullVoxPopuli
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since #1594 we have been using pnpm to pin our node version using
.npmrcto set theuse-node-versionsetting.This was fine for local development, but for CI we wanted to rely on a floating major for Node so that it was more in-line with our
--no-lockfilepolicy and might show up some issues quicker. To achieve this we overwrote the .npmrc file to remove theuse-node-versionsettingThis is what was getting picked up by the CI job as being an uncommitted change, so I made it possible to opt-out of this behaviour in our setup action 👍