Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use leaflet and react-leaflet as external packages #147

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

pikhovkin
Copy link
Contributor

See the beginning here

@pikhovkin
Copy link
Contributor Author

@emilhe emilhe merged commit 9e65df2 into emilhe:master Jul 20, 2022
@emilhe
Copy link
Owner

emilhe commented Jul 20, 2022

@pikhovkin Sorry for the long wait time, I have been caught up in other stuff. In the raw form, I had some issues with resource loading while testing the PR. I have merged the PR though, and I am now working on getting the resource loading working. When I get it working, I will push a new release.

@pikhovkin
Copy link
Contributor Author

@emilhe thank you for the merge. Now it remains for these guys to approve this merge so that plugins work.

@emilhe
Copy link
Owner

emilhe commented Jul 20, 2022

@pikhovkin Did you do any testing of loading of async components after implementing your change? It seems after merging the PR, externally developed components work, but async loaded chunks that are part of dash-leaflet itself no longer works,

Screenshot 2022-07-20 at 20 42 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants