Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty grids repeatedly requesting a discard #5133

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix empty grids repeatedly requesting a discard #5133

merged 1 commit into from
Sep 20, 2024

Conversation

lucasmerlin
Copy link
Collaborator

@lucasmerlin lucasmerlin commented Sep 19, 2024 •
edited
Loading

This does cause a slight difference in the amount of space allocated by a empty grid, is this a problem?
Before:

image

After:

image

emilk
emilk approved these changes Sep 19, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I don't think the minor size difference is worth losing sleep over

@emilk emilk merged commit 9ba97a9 into master Sep 20, 2024
42 checks passed
@emilk emilk deleted the lucas/fix-empty-grid-request-discard branch September 20, 2024 07:08
@torokati44 torokati44 mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui exclude from changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting PERF_WARNING: request_discard has been called X frames in a row
2 participants
@lucasmerlin @emilk