Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memoize] Migrate to TypeScript #2427

Merged
merged 6 commits into from
Aug 14, 2021

Conversation

sarayourfriend
Copy link
Contributor

@sarayourfriend sarayourfriend commented Jul 12, 2021

What:

Migrates the memoize package to TypeScript. This is a simple migration really. The main difference from the flow types was just needing to declare a name for the callback function's argument.

Why:

Part of #2358

How:

I renamed the index.js file to index.ts and then uncommented the Flow types and then updated them to TypeScript.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete
  • Changeset

I think the best way to test this is by running yarn build memoize and then verifying that the dist/declarations/src/index.d.ts file is correct.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2021

🦋 Changeset detected

Latest commit: 1fe749f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@emotion/memoize Minor
@emotion/babel-plugin Patch
@emotion/cache Patch
@emotion/css-prettifier Patch
@emotion/is-prop-valid Patch
@emotion/serialize Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1fe749f:

Sandbox Source
Emotion Configuration

@sarayourfriend
Copy link
Contributor Author

sarayourfriend commented Jul 12, 2021

I think I may have messed up the changeset 😞 Is a changeset necessary for each individual migration PR or will we just have a single changeset when the ts-migration branch is merged? @Andarist

@Andarist
Copy link
Member

I think I may have messed up the changeset 😞 Is a changeset necessary for each individual migration PR or will we just have a single changeset when the ts-migration branch is merged? @Andarist

Probably best to create a changeset per individual migration PR - you deserve the attribution in the generated (based on those changesets) changelog! 😉

@Andarist Andarist merged commit 7f8db2d into emotion-js:ts-migration Aug 14, 2021
@github-actions github-actions bot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants