Skip to content

Commit

Permalink
Error on use of fastcomp (#11831)
Browse files Browse the repository at this point in the history
See #11319
  • Loading branch information
sbc100 committed Aug 7, 2020
1 parent 0c667ed commit 42f4492
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ executors:
EMCC_CORES: "4"
EMSDK_NOTTY: "1"
PYTHON_BIN: "python3"
EMCC_ALLOW_FASTCOMP: "1"
mac:
environment:
EMSDK_NOTTY: "1"
Expand Down
7 changes: 4 additions & 3 deletions emcc.py
Original file line number Diff line number Diff line change
Expand Up @@ -1278,10 +1278,11 @@ def get_last_setting_change(setting):
# we also do not support standalone mode in fastcomp.
shared.Settings.STANDALONE_WASM = 1

# We allow this warning to be supressed by the environment so that we can run the test
# suite against fastcomp while supressing this warning.
# We allow this error to be supressed by the environment so that we can run the test
# suite against fastcomp for the time being.
# See: https://github.com/emscripten-core/emscripten/issues/11319
if not shared.Settings.WASM_BACKEND and 'EMCC_ALLOW_FASTCOMP' not in os.environ:
diagnostics.warning('fastcomp', 'the fastomp compiler is deprecated. Please switch to the upstream llvm backend as soon as possible and open issues if you have trouble doing so')
exit_with_error('the fastcomp compiler is no longer available in emscripten. Please use the upstream llvm backend or use an older (< 2.0.0) version of emscripten.')

if options.no_entry or ('_main' not in shared.Settings.EXPORTED_FUNCTIONS and
'__start' not in shared.Settings.EXPORTED_FUNCTIONS):
Expand Down

0 comments on commit 42f4492

Please sign in to comment.