Skip to content

Commit

Permalink
Avoid use of port 8088 in socket tests. NFC (#21512)
Browse files Browse the repository at this point in the history
This port is used by the goma compiler webserver which causes these
tests to fail on machines that are running the goma compiler.
  • Loading branch information
sbc100 committed Mar 11, 2024
1 parent a589a22 commit 92cb07a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/websocket/nodejs_websocket_echo_server.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function hexDump(bytes) {
}

var decoder = new TextDecoder('utf-8');
var port = 8088;
var port = 8089;
var ws = require('ws');
var wss = new ws.WebSocketServer({ port: port });
console.log('WebSocket server listening on ws://localhost:' + port + '/');
Expand Down
2 changes: 1 addition & 1 deletion test/websocket/test_websocket_send.c
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ int main()
EmscriptenWebSocketCreateAttributes attr;
emscripten_websocket_init_create_attributes(&attr);

const char *url = "ws://localhost:8088/";
const char *url = "ws://localhost:8089/";
attr.url = url;
attr.protocols = "binary,base64"; // We don't really use a special protocol on the server backend in this test, but check that it can be passed.

Expand Down

0 comments on commit 92cb07a

Please sign in to comment.