Remove unused 2nd pass from runJSify. NFC #18236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to understand exactly what both passes do before modifying this code, so I unrolled function into two copies - separately for each pass, one with `mainPass = true` and one with `mainPass = false` - then removed dead/unreachable code in each of those copies, and... the 2nd pass didn't have anything left.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to understand exactly what both passes do before making some modifications to this code, so I unrolled the function into two copies, separately for each pass, then removed dead/unreachable code in each of those copies, and... the 2nd pass didn't have anything left.
Looks like it should be safe to remove and simplify the function a little.