Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug range checks for makeSetValue #19251

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Add debug range checks for makeSetValue #19251

merged 1 commit into from
Apr 29, 2023

Commits on Apr 28, 2023

  1. Add debug range checks for makeSetValue

    Trying to store a value outside the range of the type being stored to
    can result in unexpected behaviour.  For example, storing 256 to a u8
    will end up storing 1.
    
    Adding these checks discovered real bug in out library code in
    `getaddrinfo`.
    
    I ran the full other and core test suite with these checks enabled
    at ASSERTIONS=1 before deciding to use ASSERTIONS=2, at least for now.
    sbc100 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    0af6c79 View commit details
    Browse the repository at this point in the history