Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChangeLog.md typo: INCOMING_MODULE_API should be INCOMING_MODULE_JS_API #21314

Merged
merged 3 commits into from
Feb 13, 2024
Merged

ChangeLog.md typo: INCOMING_MODULE_API should be INCOMING_MODULE_JS_API #21314

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
203e426
ChangeLog.md type: INCOMING_MODULE_API should be INCOMING_MODULE_JS_A…
curiousdannii Feb 12, 2024
2675feb
Also add a line break to 3.1.35 [ci skip]
curiousdannii Feb 12, 2024
1f5bf91
Merge branch 'main' into patch-1
kripken Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,10 @@ See docs/process.md for more on how version tagging works.
- The `--minify=0` command line flag will now preserve comments as well as
whitespace. This means the resulting output can then be run though closure
compiler or some other tool that gives comments semantic meaning. (#20121)
- `-sSTRICT` now implies `-sINCOMING_MODULE_API=[]` which is generally good
- `-sSTRICT` now implies `-sINCOMING_MODULE_JS_API=[]` which is generally good
for code size. If you `-sSTRICT` you now need to be explicit about the
incoming module APIs you are supplying. Users who supply symbols on the
incoming module but forget to include them in `-sINCOMING_MODULE_API`
incoming module but forget to include them in `-sINCOMING_MODULE_JS_API`
will see an error in debug builds so this change will not generate any
silent failures.
- JS library decorators such as `__deps` and `__async` are now type checked so
Expand Down Expand Up @@ -359,6 +359,7 @@ See docs/process.md for more on how version tagging works.
- stringToUTF8Array
- stringToUTF8
- lengthBytesUTF8

sbc100 marked this conversation as resolved.
Show resolved Hide resolved
If you use any of these functions in your JS code you will now need to include
them explicitly in one of the following ways:
- Add them to a `__deps` entry in your JS library file (with leading $)
Expand Down
Loading