Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contrib.glfw3] new version (workaround / bug fix) #22141

Merged

Conversation

ypujante
Copy link
Contributor

I released a new version of contrib.glfw3 with a workaround/bug fix. I wanted to point out that there is the same issue that was created on 10/22 for the built-in implementation. That was never addressed. I also wanted to point out that SDL2 also suffers from the same issue...

I found this issue while working on a project using ImGui.

Meta_V

Release notes:

  • Implemented workaround for #4: Using Super + "Key" on macOS results in "Key" not being released.
    Due to the broken state of javascript handling the Super/Meta key, there is no good solution. The workaround implemented, releases all keys when Super is released. Although not a perfect solution, it guarantees that the state is eventually consistent:
    • if "Key" was released while "Super" was held, then when "Super" gets released, "Key" is released (later than when actually released, final state is consistent: "Key" in Release state)
    • if "Key" is still held when "Super" is released, "Key" is released when "Super" gets released, but immediately gets a down event (Up/Down event, final state is consistent": "Key" in Pressed state)

@sbc100 sbc100 merged commit db9b1fb into emscripten-core:main Jun 25, 2024
28 checks passed
@ypujante ypujante deleted the emscripten-glfw-3.4.0.20240625 branch August 25, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants