Disable fastcomp installation for sdk versions 2.0.0 and above #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Aug 5, 2020
| @@ -2672,6 +2672,9 @@ def expand_sdk_name(name): | |||
| backend = 'upstream' | |||
| else: | |||
| backend = 'fastcomp' | |||
| if backend == 'fastcomp' and version_key(fullname) >= (2, 0, 0): | |||
| print('Note: fastcomp is not longer available in version 2.0.0 and above') | |||
| return name | |||
There was a problem hiding this comment.
it might be safer to error here? both code-wise it would be clearer that everything halts here. and the error for users would be better I think.
There was a problem hiding this comment.
The error this produces seems pretty good to me:
$ ./emsdk install 2.0.0-fastcomp
Note: fastcomp is not longer available in version 2.0.0 and above.
Error: No tool or SDK found by name '2.0.0-fastcomp'.
Basically we are failing expand the input given by the user and then the calling code displays the same error the would see if they had made any other kind of typo or something.
There was a problem hiding this comment.
I don't love the fact that it depends on 2.0.0-fastcomp not existing and being errored on elsewhere, when we know this should fail right here. But that's a reasonable error.
| @@ -2672,6 +2672,9 @@ def expand_sdk_name(name): | |||
| backend = 'upstream' | |||
| else: | |||
| backend = 'fastcomp' | |||
| if backend == 'fastcomp' and version_key(fullname) >= (2, 0, 0): | |||
| print('Note: fastcomp is not longer available in version 2.0.0 and above') | |||
There was a problem hiding this comment.
Suggested change
| print('Note: fastcomp is not longer available in version 2.0.0 and above') | |
| print('Note: fastcomp is not longer available in version 2.0.0 and above. please use either the upstream backend, or an earlier fastcomp version') |
|
Closing in favor of #584 |
vargaz
pushed a commit
to vargaz/emsdk
that referenced
this pull request
Nov 22, 2023
emscripten-core#581) * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231030.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.23527.1 -> To Version 9.0.0-alpha.1.23530.1 * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231030.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.23527.1 -> To Version 9.0.0-alpha.1.23530.1 * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231101.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.23527.1 -> To Version 9.0.0-alpha.1.23551.1 * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231102.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.23527.1 -> To Version 9.0.0-alpha.1.23552.1 * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231102.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.23527.1 -> To Version 9.0.0-alpha.1.23552.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See emscripten-core/emscripten#11319